promote ascii functions to elemental #886
Merged
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perazz
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
I believe I remember that some older versions of gfortran had issues with elemental functions and character . However, that seems not an issue here as all tests pass with all supported gfortran versions. LGTM, thank you @jalvesz
|
Do you remember if it was a compile-time problem or a run-time problem? maybe it would be better to add array-like tests also ? I don't recall running into such problems. |
|
I can't find a link right now in my bugzilla - I suggest we wait for another while, and if no further comments arise, this PR can be merged imho. |
|
On my side I think it could be merged. The fails in the macOS CI are due to an update in github, which can be fixed in another PR. |
|
Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote ascii functions from pure to elemental for potentially better optimization and ease use for array expressions manipulation.